[FLINK-38417] Ensure attribute ordering when managing join attributes in JoinKeyExtractor #27033
+870
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
reviewed
Sep 23, 2025
| * <p>Example used throughout the comments: t1.id1 = t2.user_id2 and t3.user_id3 = t2.user_id2. All | ||
| * three attributes (t1.id1, t2.user_id2, t3.user_id3) represent the same conceptual key. | ||
| * | ||
| * <p>The {@code joinAttributeMap} for this example would be structured as follows: |
There was a problem hiding this comment.
Thanks for this example. Way easier to understand!
| userIdFieldName, pkFieldName, String.format("details_%d", inputIndex) | ||
| }); | ||
| } else if (inputIndex | ||
| == 3) { // Shipments: user_id (VARCHAR), pk (VARCHAR), details (BIGINT) |
There was a problem hiding this comment.
Suggested change
| == 3) { // Shipments: user_id (VARCHAR), pk (VARCHAR), details (BIGINT) | |
| == 3) { // Shipments: user_id (CHAR NOT NULL), pk (VARCHAR), details (BIGINT) |
| String userIdFieldName = String.format("user_id_%d", inputIndex); | ||
| String pkFieldName = String.format("pk_%d", inputIndex); // Generic PK name | ||
|
|
||
| if (inputIndex == 0) { // Users: user_id (VARCHAR), pk (VARCHAR), details (BIGINT) |
There was a problem hiding this comment.
Suggested change
| if (inputIndex == 0) { // Users: user_id (VARCHAR), pk (VARCHAR), details (BIGINT) | |
| if (inputIndex == 0) { // Users: user_id (CHAR NOT NULL), pk (VARCHAR), details (BIGINT) |
| + "k3 BOOLEAN," | ||
| + "k2 INT," | ||
| + "k4 STRING") | ||
| .addOption("changelog-mode", "I") |
There was a problem hiding this comment.
Use the new addMode(ChangelogMode.insertOnly())
| "k2 INT", | ||
| "k3 BOOLEAN", | ||
| "k4 STRING") | ||
| .addOption("changelog-mode", "I,UA,UB,D") |
There was a problem hiding this comment.
Use the new addMode(ChangelogMode.all())
| .addSchema( | ||
| "`record_id` STRING PRIMARY KEY NOT ENFORCED", | ||
| "`user_id` INT") | ||
| .addOption("changelog-mode", "I,UA,D") |
There was a problem hiding this comment.
Use the new addMode(ChangelogMode.upsert())
|
Thanks for the review, @twalthr! I've addressed the comments and replaced all changelogs with the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The MultiJoin has a JoinKeyExtractor helper that derives keys from AttributeRef mappings in the joinAttributeMap. It describes how attributes from different inputs are equated via equi-join * conditions.
The methods present in the JoinKeyExtractor should always return rows for the join conditions and commonJoinKey in the same order so we have stable a joinKey for state access and key selector for routing. This adds a fix to make sure the order is maintained.
To make the whole class easier to read, I've also refactored it, added comments and examples.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation