[server] Support AddServerTag and RemoveServerTag #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiebingYu
reviewed
Jul 24, 2025
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Show resolved
Hide resolved
Open
2 tasks
swuferhong
force-pushed
the
add-server-tag
branch
from
2368e6a to
d24c6d7
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
swuferhong
force-pushed
the
add-server-tag
branch
2 times, most recently
from
1889c56 to
d7a7352
Compare
swuferhong
force-pushed
the
add-server-tag
branch
2 times, most recently
from
17d0124 to
170a35e
Compare
LiebingYu
reviewed
Oct 23, 2025
| @Override | ||
| public CompletableFuture<AddServerTagResponse> addServerTag(AddServerTagRequest request) { | ||
| throw new UnsupportedOperationException("Support soon!"); | ||
| CompletableFuture<AddServerTagResponse> response = new CompletableFuture<>(); |
Contributor
There was a problem hiding this comment.
Missing permission control?
Contributor
Author
There was a problem hiding this comment.
Maybe we can support this in a separate PR later. Additionally, I noticed that the RPC listOffsets also lacks permission control—we could address this together in the same issue.
LiebingYu
reviewed
Oct 23, 2025
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
Show resolved
Hide resolved
swuferhong
force-pushed
the
add-server-tag
branch
from
170a35e to
7f45297
Compare
swuferhong
force-pushed
the
add-server-tag
branch
from
7f45297 to
5255b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1388
This pr is aims to support AddServerTag and RemoveServerTag.
Brief change log
Tests
API and Format
Documentation