[lake] Record a file path storing log offsets in lake snapshot property #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
33969e9 to
5442462
Compare
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
5442462 to
68a5039
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperator.java
Outdated
Show resolved
Hide resolved
...ink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperator.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/org/apache/fluss/server/coordinator/TestCoordinatorGateway.java
Outdated
Show resolved
Hide resolved
fluss-rpc/src/test/java/org/apache/fluss/rpc/TestingTabletGatewayService.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/org/apache/fluss/server/tablet/TestTabletServerGateway.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fluss/flink/tiering/committer/FlussTableLakeSnapshotCommitter.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/lake/committer/CommittedLakeSnapshot.java
Show resolved
Hide resolved
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
2 times, most recently
from
06af001 to
3889069
Compare
luoyuxia
changed the title
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
a6c7f69 to
747e91b
Compare
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
747e91b to
f31d6f5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 42 out of 42 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fluss-server/src/main/java/org/apache/fluss/server/zk/data/lake/LakeTableJsonSerde.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fluss/flink/tiering/committer/FlussTableLakeSnapshotCommitter.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/zk/data/lake/LakeTableHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 43 out of 43 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperator.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/entity/CommitLakeTableSnapshotData.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java
Show resolved
Hide resolved
...common/src/test/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperatorTest.java
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/utils/json/TableBucketOffsetsJsonSerdeTest.java
Show resolved
Hide resolved
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
37c8016 to
f7a09fa
Compare
luoyuxia
force-pushed
the
allow-commit-offset-to-fluss
branch
from
f7a09fa to
f470b32
Compare
Contributor
Author
|
@wuchong Could you please help review this pr? The pr also handle the back compabitlity when use v2 to serialize lake table snapshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2224
Brief change log
TieringCommitOperator, first prepare commit log offsets to fluss cluster which will write a file to store the log offsetsTests
Existing test
API and Format
Documentation