Skip to content

fix:Add check for empty search results to prevent array out of bounds #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

fix:Add check for empty search results to prevent array out of bounds #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../geaflow-store-vector/src/main/java/org/apache/geaflow/store/lucene/GraphVectorIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ public K searchVectorIndex(boolean isVertex, String fieldName, float[] vector, i
// Execute search
TopDocs topDocs = searcher.search(knnQuery, topK);

if (topDocs.scoreDocs.length == 0) {
return null;
}

Document firstDoc = searcher.doc(topDocs.scoreDocs[0].doc);

K result;
Expand Down
7 changes: 7 additions & 0 deletions ...flow-store-vector/src/test/java/org/apache/geaflow/store/lucene/GraphVectorIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,11 @@ public void testMultipleVectorsSameKeyDifferentFields() {
assertEquals(result1, key);
assertEquals(result2, key);
}
@Test
public void testSearchNonExistentFieldReturnsNull() {
stringIndex.addVectorIndex(true, "vertex_1", "embedding", new float[]{0.1f, 0.2f, 0.3f, 0.4f});
// searching for a non-existent field should return null
String result = stringIndex.searchVectorIndex(true, "nonexistent_field", new float[]{0.1f, 0.2f, 0.3f, 0.4f}, 1);
assertEquals(result, null);
}
}