-
Notifications
You must be signed in to change notification settings - Fork 243
[Message Prioritization] - Add currentReplicaNumber metadata for message prioritization #3043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Message Prioritization] - Add currentReplicaNumber metadata for message prioritization #3043
Conversation
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/util/MessageUtil.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
95fc654 to
9b80190
Compare
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
|
New test results. |
…nts, renamed variables.
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/OnlineOfflineSMD.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
…move filtering out second top state to top state
helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
Outdated
Show resolved
Hide resolved
|
Generally LGTM, please address format issue and some code clean |
Hey @xyuanlu updated the PR after the last comment. could you please approve this when you get a chance. thanks |
|
LGTM. Thanks for addressing all comments :D |
|
Thanks for the review. The PR is approved by @xyuanlu . Final commit message: "Add currentReplicaNumber metadata for message prioritization by client". |
Issues
My PR addresses the following Helix issues and references them in the PR description:
Fixes Prioritize upward state transitions to improve recovery time #3042
Description
Here are some details about my PR, including screenshots of any UI changes:
Enhances Helix's message generation phase to prioritize upward state transitions from non-second top states to second top or top states.
Tests
The following tests are written for this issue:
TestPrioritizationMessageGeneration
The following is the result of the "mvn test" command on the appropriate module:
Changes that Break Backward Compatibility (Optional)
N/A
Documentation (Optional)
N/A
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)