Fix flaky test IntegrationTest_MultiSpoutsMultiTasks#1815
Fix flaky test IntegrationTest_MultiSpoutsMultiTasks#1815huijunw merged 2 commits intoapache:masterfrom huijunwu:fixMultiSpoutsMultiTasks
Conversation
|
@huijunwu - wondering if you ran the tests a few times before the flakiness is gone. |
|
Also enable #1773 ? |
|
@kramasamy Test was run hundred times; all passed |
|
Great find. I don't understand how this would make the test flaky. Why wouldn't the tests fail consistently without this fix? |
|
@billonahill |
billonahill
left a comment
There was a problem hiding this comment.
Thanks @huijunw for clarifying. Great find.
* fix flaky integration test MultiSpoutsMultiTasks * re-enable IntegrationTest_MultiSpoutsMultiTasks
Fix
#1561
#1691
#1687
#1700
The cause is:
tuple count includes 'termination tuple', which leads to multiple same acking tuples and stmgr failure to cancel out markers in xor_manager.
https://travis-ci.org/twitter/heron/builds/225447993
Fix:
count only normal tuples
https://travis-ci.org/twitter/heron/builds/225471892