Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Fix flaky test IntegrationTest_MultiSpoutsMultiTasks#1815

Merged
huijunw merged 2 commits intoapache:masterfrom
huijunwu:fixMultiSpoutsMultiTasks
Apr 25, 2017
Merged

Fix flaky test IntegrationTest_MultiSpoutsMultiTasks#1815
huijunw merged 2 commits intoapache:masterfrom
huijunwu:fixMultiSpoutsMultiTasks

Conversation

@huijunwu
Copy link
Member

Fix
#1561
#1691
#1687
#1700

The cause is:
tuple count includes 'termination tuple', which leads to multiple same acking tuples and stmgr failure to cancel out markers in xor_manager.
https://travis-ci.org/twitter/heron/builds/225447993

Fix:
count only normal tuples
https://travis-ci.org/twitter/heron/builds/225471892

@kramasamy
Copy link
Contributor

@huijunwu - wondering if you ran the tests a few times before the flakiness is gone.

@huijunw huijunw requested a review from maosongfu April 25, 2017 17:17
@huijunw huijunw added the test label Apr 25, 2017
@huijunw huijunw self-assigned this Apr 25, 2017
@objmagic
Copy link
Contributor

Also enable #1773 ?

@huijunw
Copy link
Contributor

huijunw commented Apr 25, 2017

@kramasamy Test was run hundred times; all passed
@objmagic IntegrationTest_OneSpoutBoltMultiTasks is different. More time needed.

@billonahill
Copy link
Contributor

Great find. I don't understand how this would make the test flaky. Why wouldn't the tests fail consistently without this fix?

@huijunwu
Copy link
Member Author

huijunwu commented Apr 25, 2017

@billonahill
The time when 'termination tuple' arrives at the IdentityBolt is different everytime. If a 'termination tuple' arrives between two normal tuple, the count is one more than expected and the acking tuple is one more than expected.
Usually, the 'termination tuple' is after all the normal tuples, so there is no issue.
There are 6 spouts in the test. If one of them runs fast and sends out 'termination tuple' before the other spouts sending out all normal tuples, the wrong count appears.

Copy link
Contributor

@billonahill billonahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huijunw for clarifying. Great find.

Copy link
Contributor

@objmagic objmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

Copy link
Member

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding

@huijunw huijunw merged commit 453acf2 into apache:master Apr 25, 2017
@huijunwu huijunwu deleted the fixMultiSpoutsMultiTasks branch May 4, 2017 01:55
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
* fix flaky integration test MultiSpoutsMultiTasks

* re-enable IntegrationTest_MultiSpoutsMultiTasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants