This repository was archived by the owner on Mar 3, 2023. It is now read-only.
remove three other roundings in cpu calculation#2807
Open
nwangtw wants to merge 1 commit intoapache:masterfrom
Open
remove three other roundings in cpu calculation#2807nwangtw wants to merge 1 commit intoapache:masterfrom
nwangtw wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
unit tests to update |
Member
|
What's the background of removing this |
Contributor
Author
|
It is more about "why there was a Math.rounding()". The rounding logic doesn't seem necessary if we assume cpu # can be less than fractional. Also the logic have bugs that in some cases it can be floored to 0. However when I was working on this PR, I found out that some parking algorithms rely on the rounding so this is not a quick fix. This PR needs to be revisited when I get more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.