-
Notifications
You must be signed in to change notification settings - Fork 30
Adding the license #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
squash and you get my 👍 |
|
Thank you. But I don't understand what you mean. |
|
I meant that all commits should be squashed into a single commit. Then you get my +1 :) |
|
Thank you. I'll regard that as a nice to have, and will (try to) work towards it for future actions. |
…into develop # By humbedooh # Via humbedooh * 'master' of https://github.com/apache/incubator-ponymail: fixups for NOTICE add incubator disclaimer we have a web site! update name and URL
|
Please see http://ponymail.incubator.apache.org/contribute.html#gitworkflow for instructions on how to squash/rebase your PR |
|
I am inclined to -1 this. There is far too many unnecessary changes. The markdown files and configuration snippets do NOT need license headers. Documentation and examples do historically speaking never include the license. |
|
Better check with ASF Legal as documentation is also part of the works of a product. The assertion that 'documentation and examples historically speaking never include the license' is wrong. Check the works of others in libraries (the real ones), etc. Which changes are unnecessary and which aren't? |
|
see httpd for instance - we have never put licenses in our documentation there. |
|
the LICENSE file technically covers everything else, FWIW. When not specified, the ALv2 applies to any file without an explicit license header. We put license headers in our code for two reasons: 1) we sometimes use external dependencies which may have different licenses, and we need to be able to discern which is which, and 2) code is more typically reworked or reused by external entities, so putting license headers there makes sense. Putting it in the config files is usually....useless :) |
|
Rethink that again. That is why they (the smarter ones) have invented licenses of the type of CC-BY, etc. |
|
If you can find any place that explicitly says documentation must be licensed, then fine - but I haven't found such a policy and I don't agree that we need this. I can reach out to VP Legal and get an answer if need be. |
|
I will put the question to Legal. |
|
you may want to read/consider this: |
|
Thank you for providing a factual link, Justin. This gives us some real data to assess. I would argue that the vast majority of these files (which are readme/install text files) and the configuration snippets fall under these categories. We're not talking API reference docs here, this is purely files relating to the installation of the program as well as configuration snippets meant to be added to a larger configuration. |
|
To clarify; I am not against putting license headers in a select files that may warrant it. I am against accepting this PR and putting license headers in ALL files, regardless of size and whether they need it. |
|
I wonder how legally different (with respect to copyright and such) the content in a readme.md file in the repository of the project on Github is from the content in a readme.html file in the website repository. To me they are both the same, both the work of the project, both IP of the ASF, both licensable... Yet, in the html page for the website we place a copyright statement, while in the readme.md file on Github we don't. Weird.... Best regards, Pierre |
This will bring the license header to various files