Refine CN consensus layer API for procedure robustness #16303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
reviewed
Sep 1, 2025
Comment on lines
+324
to
+328
| try { | ||
| store.update(this); | ||
| // do not release lock when consensus layer is not working | ||
| releaseLock(env); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Who will release the lock then?
Comment on lines
+480
to
+490
| try { | ||
| store.update(parent); | ||
| // do not add this procedure when exception occurred | ||
| scheduler.addFront(parent); | ||
| LOG.info( | ||
| "Finished subprocedure pid={}, resume processing ppid={}", | ||
| proc.getProcId(), | ||
| parent.getProcId()); | ||
| } catch (Exception e) { | ||
| LOG.warn("Failed to update parent on countdown", e); | ||
| } |
There was a problem hiding this comment.
Is solely printing a log enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detailed docs: https://apache-iotdb-project.feishu.cn/wiki/QCEcwDevEiGSjgkUiZ6cMBHdnFg