JCRVLT-821: update max test versions to Oak 1.84.0 and Jackrabbit 2.22.2 #388
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,18 +37,18 @@ | |
| <jackson.version>2.13.4</jackson.version> | ||
| </properties> | ||
|
|
||
| <!-- the following dependencies are provided by AEMaaCS, all must have scope "provided" to prevent them polluting referencing modules --> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.felix</groupId> | ||
| <artifactId>org.apache.felix.framework</artifactId> | ||
| <version>7.0.5</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.felix</groupId> | ||
| <artifactId>org.apache.felix.scr</artifactId> | ||
| <version>2.2.12</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- transitive deps of felix.scr --> | ||
|
|
@@ -79,7 +79,7 @@ | |
| <dependency> | ||
| <groupId>org.apache.felix</groupId> | ||
| <artifactId>org.apache.felix.http.servlet-api</artifactId> | ||
| <version>2.1.0</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
|
|
@@ -91,14 +91,14 @@ | |
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>jcl-over-slf4j</artifactId> | ||
| <version>1.7.36</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- required SLF4J Impl capability --> | ||
| <dependency> | ||
| <groupId>org.apache.sling</groupId> | ||
| <artifactId>org.apache.sling.commons.log</artifactId> | ||
| <version>5.5.0</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
|
|
@@ -116,31 +116,31 @@ | |
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.20.0</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>3.18.0</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-collections4</artifactId> | ||
| <version>4.5.0</version> | ||
|
Member
There was a problem hiding this comment. Why is this necessary in this context? IMHO the max versions are never used to calculate import package version ranges....
Member
There was a problem hiding this comment. Sorry, indeed we are embedding the max versions of some JR2 artifacts even in the OSGi bundles. Should we rethink this? Currently those are jackrabbit-filevault/vault-core/bnd.bnd Line 20 in 4806680
Contributor
Author
There was a problem hiding this comment. The requirement comes from the fact that otherwise ITs fails because they need 4.5.0. |
||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.19.0</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.sling</groupId> | ||
| <artifactId>org.apache.sling.api</artifactId> | ||
| <version>2.27.6</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!--transitive dep of sling.api --> | ||
|
|
@@ -189,7 +189,7 @@ | |
| <dependency> | ||
| <groupId>org.apache.sling</groupId> | ||
| <artifactId>org.apache.sling.jcr.base</artifactId> | ||
| <version>3.1.14</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
|
|
@@ -216,6 +216,5 @@ | |
| <version>${jackson.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line40 the comment must be changed (was wrong right from the beginning), it used to reflect the bundles provided by some AEMaaCS version.