[WIP]KAFKA-15444: Native docker image#14556
[WIP]KAFKA-15444: Native docker image#14556kagarwal06 wants to merge 62 commits intoapache:trunkfrom
Conversation
| process(args) | ||
| } | ||
|
|
||
| def process(args: Array[String]): Unit = { |
There was a problem hiding this comment.
Why is process needed? You can invoke main from KafkaNativeWrapper.
docker/test/requirements.txt
Outdated
| @@ -0,0 +1,6 @@ | |||
| confluent_kafka | |||
There was a problem hiding this comment.
It seems like it's a typo. Updating it to confluent-kafka
There was a problem hiding this comment.
But why would we depend on a confluent kafka artifact.
There was a problem hiding this comment.
@ijuma Confluent Kafka for Python - https://github.com/confluentinc/confluent-kafka-python
confluent-kafka is a python client compatible with kafka
For sanity tests of docker images we wanted a python client to interact with kafka residing in docker image, hence we went ahead with this publicly available and widely used python client.
We are open to consider alternate python clients if there are any concerns in using this library
There was a problem hiding this comment.
Can we not use the CLI tools that are included in the Apache Kafka project?
There was a problem hiding this comment.
This suggestion has been incorporated. Now we are using CLI scripts included in kafka.
There was a problem hiding this comment.
Can we remove confluent_kafka from here then?
Remove confluent kafka python client as dependency Remove schema registry and connect from compose files Download kafka binary and use it's scripts to run tests
- Remove zookeeper support & tests - Optimise image by removing redundant packages - Minor code fixes
Changes to add support for file mounting of properties. Env variables, if defined, will override the file input properties.
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
4 participants
This PR includes the changes for
native-binarydocker image for Apache Kafka corresponding to the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-974%3A+Docker+Image+for+GraalVM+based+Native+Kafka+BrokerNOTE 1 This PR is dependent on #14552, hence should be merged post merging #14552
NOTE 2: The changes are made on top of the #14552 as we had common code. Hence this contains changes for the JVM Docker Image as well
NOTE 3: To view Native-Image specific changes, refer: VedarthConfluent#1
Committer Checklist (excluded from commit message)