KAFKA-19703: Removed versions 2.3 and below from UpgradeFromValues. #20539
Conversation
|
It seems we should also update the docs here: https://github.com/apache/kafka/blob/trunk/docs/streams/developer-guide/config-streams.html#L1237-L1238 The last sentence does not apply any longer. |
|
Also for the upgrade guide: https://github.com/apache/kafka/blob/trunk/docs/streams/upgrade-guide.html |
….3 and below versions.
| You should set this config to the appropriate version before bouncing your instances and upgrading them to the newer version. Once everyone is on the | ||
| newer version, you should remove this config and do a second rolling bounce. It is only necessary to set this config and follow the two-bounce upgrade path | ||
| when upgrading from below version 2.0, or when upgrading to 2.4+ from any version lower than 2.4. | ||
| when upgrading to 3.4+ from any version lower than 3.4. |
There was a problem hiding this comment.
I changed to 3.4 to align with the upgrade guide. if it's incorrect, please let me know, I will fix it
| <p> As an alternative, an offline upgrade is also possible. Upgrading from any versions as old as 0.10.0.x to {{fullDotVersion}} in offline mode require the following steps: </p> | ||
| <ul> | ||
| <li> stop all old (e.g., 0.10.0.x) application instances </li> | ||
| <li> update your code and swap old code and jar file with new code and new jar file </li> |
There was a problem hiding this comment.
Cannot comment above, but it say:
As an alternative, an offline upgrade is also possible. Upgrading from any versions as old as 0.10.0.x to {{fullDotVersion}} in offline mode require the following steps:
And stop all old (e.g., 0.10.0.x) application instances.
That's not correct any longer. Let's bump 0.10.0.x to `0.11.0.
I am also wondering if we should whole paragraphs Streams API changes in XXX for at least all 0.10.0.x and 0.10.1.x releases. Maybe even more (ie, up-to-including 2.3.x, we we only support rolling-bounce upgrade from 2.4+ as oldest version to 4.0+ now), and add a sentence + link to eg 3.9 docs for these older versions?
| for more details. | ||
| </p> | ||
|
|
||
| <p>For a table that shows Streams API compatibility with Kafka broker versions, see <a href="#streams_api_broker_compat">Broker Compatibility</a>.</p> |
There was a problem hiding this comment.
Further below, there is more stuff, that seems to be old and we can remove it?
To run a Kafka Streams application version 2.2.1, 2.3.0, or higher a broker version 0.11.0 or higher is required and the on-disk message format must be 0.11 or higher. [...]
Ie, the whole two paragraphs?
Removed versions 2.3 and below from UpgradeFromValues, including all the
usagesof them.
Reviewers: Matthias J. Sax matthias@confluent.io