KAFKA-19664 Support building with Java 25 (LTS release) #20561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion (i.e. file `unixStartScript.txt`) was being referenced
details:
- gradle: 8.14.3 -->> 9.0.0
- https://github.com/gradle/gradle/releases/tag/v9.0.0
- https://gradle.org/whats-new/gradle-9
- https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#changes_major_9
- shadow plugin: 8.3.6 -->> 9.0.2
- https://github.com/GradleUp/shadow/releases/tag/9.0.0
- https://github.com/GradleUp/shadow/releases/tag/9.0.1
- https://github.com/GradleUp/shadow/releases/tag/9.0.2
refactoring (performed in order to accomodate Gradle 9 breaking changes):
- tasks `siteDocsTar` and `releaseTarGz` are moved out of `core` (and into a new dummy module: `distribution`); note that distribution destination folder stays as-is (:core)
- `preserveFileTimestamps` Tar taks property value explicitly set to `true` (default values: Gradle 8: `true`, Gradle 9: 'false')
- files and folders permissions are introduced
- git placeholder file (.gitkeep) is added in order to preserve `distribution` folder (Apache Rat check for that file is skipped)
- `wrapper.gradle` changes: no need to check number of dots for Gradle versions >=9 anymore
- redundant 'gradleVersion' ext property is removed (in favor of 'versions.gradle' usage)
… dependencies/plugins and GitHub Actions details: - `setup-gradle` GitHub Action: 4.3.0 -->> 4.4.3 (note: this version was tested against Gradle 9) - grgit: 4.1.1 -->> 5.3.0 - gradle versions plugin: 0.48.0 -->> 0.52.0 - owasp dependency check : 8.2.1 -->> 12.1.3 - spotbugs: 6.2.3 -->> 6.2.5 - spotless: 6.25.0 -->> 7.2.1 - Zinc Scala compiler: 1.9.2 -->> 1.10.8
… a `upgrade-system-tests*` submodules related link: https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#test_task_fails_when_no_tests_are_discovered
…hen no test are discovered (i.e. solution for KAFKA-16801 is expanded)
details: support for Java 25: https://docs.gradle.org/9.1.0/release-notes.html#support-for-java-25
note: spotbugs related Gradle tasks temporarily are disabled for Java 25
github-actions
bot
added
triage
…o more places) note: `build / JUnit tests Java 25-ea` Github Action results with a previous commit: https://github.com/apache/kafka/actions/runs/17853628508/job/50769215024?pr=20561 ``` Gradle task had a failure exit code. Failing this script. 25373 tests cases run in 1h17m30s. 17471 PASSED ✅, 5676 FAILED ❌, 0 FLAKY⚠️ , 0 SKIPPED 🙈, 0 QUARANTINED 😷, and 0 errors. Error: Process completed with exit code 1. Error: $GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 6145k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary ```
|
Thank you @brandboat 👌 |
ijuma
reviewed
Sep 23, 2025
.github/workflows/build.yml
Outdated
| matrix: | ||
| # If we change these, make sure to adjust ci-complete.yml | ||
| java: [ 24, 17 ] | ||
| java: [ 25-ea, 17 ] |
There was a problem hiding this comment.
Why is this "25-ea" instead of "25"?
There was a problem hiding this comment.
Version 25 is still pending:
- September 2025 Release Status per Platform, Version & Binary Type adoptium/temurin#96
- Support JDK 25 (LTS) actions/setup-java#899
Also, there is an internal prerequisite: #19513
…ed on two more places)" This reverts commit ff1add5.
|
It seems that Github Actions now supports Java 25 build; let's test that. |
|
Lots of test are failing when tested against Java 25: |
|
And also: some references to Java 24 are still present. |
|
@dejan2609 The references to Java 24 are likely due to #20295 (comment) It might make sense to add a comment to ci-complete.yml, so the next person to come across this doesn't have to figure that out again :) |
|
Much obliged @srdo ! I was this close from digging into all related commits/PR's to figure out what is going on: Yes, it does make sense to add a small comment, I will do that for sure 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Related JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-19664
Note: solution based on @srdo work here:
FYI @chia7712