Skip to content

Conversation

@git-hulk
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.44%. Comparing base (6c56470) to head (b604bf4).
⚠️ Report is 88 commits behind head on unstable.

Files with missing lines Patch % Lines
store/cluster_node.go 0.00% 3 Missing ⚠️
controller/cluster.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #355      +/-   ##
============================================
+ Coverage     43.38%   47.44%   +4.05%     
============================================
  Files            37       45       +8     
  Lines          2971     4454    +1483     
============================================
+ Hits           1289     2113     +824     
- Misses         1544     2133     +589     
- Partials        138      208      +70     
Flag Coverage Δ
unittests 47.44% <0.00%> (+4.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@git-hulk git-hulk marked this pull request as ready for review September 27, 2025 05:56
@git-hulk
Copy link
Member Author

It still has the flaky condition after the last fix. The root cause is that multiple test cases are sharing the same kvrocks cluster, and their migration status will affect each other. I have rerun it a few times, and it should be stable after this fix.

@git-hulk
Copy link
Member Author

@PragmaTwice Thanks for your prompt review. Another issue to be improved is that cluster.Reset() should first flush the master node and then reset the other replicas. Or it may fail to reset replicas because some data is left inside the instance.

@git-hulk git-hulk merged commit b37b4c9 into apache:unstable Sep 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants