Skip to content

Optimize prefix sum #15194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Optimize prefix sum #15194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d4147
optimize prefix sums
dungba88 Sep 17, 2025
de5e2a4
tidy
dungba88 Sep 17, 2025
247a61d
revert formatting change
dungba88 Sep 17, 2025
76ba519
modify checksum
dungba88 Sep 17, 2025
7ec09be
fix error
dungba88 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lucene/backward-codecs/src/generated/checksums/generateForDeltaUtil101.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/ForDeltaUtil.java": "29fd59e9847d3012497c3079fa7ebc4f68fa6a94",
"lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/ForDeltaUtil.java": "19ddcb5229ae0a3b5c14f9c8a2fca5e811a7b172",
"lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/gen_ForDeltaUtil.py": "147b81236bc0373fe97e808c0ae7a2cb6276ae5a"
}
7 changes: 4 additions & 3 deletions ...ne/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/ForDeltaUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ private static void prefixSum16(int[] arr, int base) {
}

private static void prefixSum32(int[] arr, int base) {
arr[0] += base;
for (int i = 1; i < BLOCK_SIZE; ++i) {
arr[i] += arr[i - 1];
int sum = base;
for (int i = 0; i < BLOCK_SIZE; ++i) {
sum += arr[i];
arr[i] = sum;
}
}

Expand Down
13 changes: 8 additions & 5 deletions ...-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,11 @@ public void init(IndexInput termsIn, SegmentReadState state) throws IOException
}
}

static void prefixSum(int[] buffer, int count, long base) {
buffer[0] += base;
for (int i = 1; i < count; ++i) {
buffer[i] += buffer[i - 1];
static void prefixSum(int[] buffer, int count, int base) {
int sum = base;
for (int i = 0; i < count; ++i) {
sum += buffer[i];
buffer[i] = sum;
}
}

Expand Down Expand Up @@ -606,8 +607,10 @@ private void refillFullBlock() throws IOException {
for (int i = 0; i < numLongs - 1; ++i) {
docCumulativeWordPopCounts[i] = Long.bitCount(docBitSet.getBits()[i]);
}
int sum = docCumulativeWordPopCounts[0];
for (int i = 1; i < numLongs - 1; ++i) {
docCumulativeWordPopCounts[i] += docCumulativeWordPopCounts[i - 1];
sum += docCumulativeWordPopCounts[i];
docCumulativeWordPopCounts[i] = sum;
}
docCumulativeWordPopCounts[numLongs - 1] = BLOCK_SIZE;
assert docCumulativeWordPopCounts[numLongs - 2]
Expand Down
8 changes: 6 additions & 2 deletions ...che/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingTermVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,10 @@ public Fields get(int doc) throws IOException {
// delta-decode start offsets and patch lengths using term lengths
final int termLength = fPrefixLengths[j] + fSuffixLengths[j];
lengths[i][positionIndex[i][j]] += termLength;
int sum = fStartOffsets[positionIndex[i][j]];
for (int k = positionIndex[i][j] + 1; k < positionIndex[i][j + 1]; ++k) {
fStartOffsets[k] += fStartOffsets[k - 1];
sum += fStartOffsets[k];
fStartOffsets[k] = sum;
fLengths[k] += termLength;
}
}
Expand All @@ -565,8 +567,10 @@ public Fields get(int doc) throws IOException {
if (fPositions != null) {
for (int j = 0, end = (int) numTerms.get(skip + i); j < end; ++j) {
// delta-decode start offsets
int sum = fPositions[fpositionIndex[j]];
for (int k = fpositionIndex[j] + 1; k < fpositionIndex[j + 1]; ++k) {
fPositions[k] += fPositions[k - 1];
sum += fPositions[k];
fPositions[k] = sum;
}
}
}
Expand Down
7 changes: 4 additions & 3 deletions ...rd-codecs/src/java/org/apache/lucene/backward_codecs/lucene84/Lucene84PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,10 @@ static void readVIntBlock(
}

static void prefixSum(long[] buffer, int count, long base) {
buffer[0] += base;
for (int i = 1; i < count; ++i) {
buffer[i] += buffer[i - 1];
long sum = base;
for (int i = 0; i < count; ++i) {
sum += buffer[i];
buffer[i] = sum;
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...rd-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ static void readVIntBlock(
}

static void prefixSum(long[] buffer, int count, long base) {
buffer[0] += base;
for (int i = 1; i < count; ++i) {
buffer[i] += buffer[i - 1];
long sum = base;
for (int i = 0; i < count; ++i) {
sum += buffer[i];
buffer[i] = sum;
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...-codecs/src/java/org/apache/lucene/backward_codecs/lucene912/Lucene912PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,10 @@ public void init(IndexInput termsIn, SegmentReadState state) throws IOException
}

static void prefixSum(long[] buffer, int count, long base) {
buffer[0] += base;
for (int i = 1; i < count; ++i) {
buffer[i] += buffer[i - 1];
long sum = base;
for (int i = 0; i < count; ++i) {
sum += buffer[i];
buffer[i] = sum;
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...rd-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,10 @@ public void init(IndexInput termsIn, SegmentReadState state) throws IOException
}

static void prefixSum(long[] buffer, int count, long base) {
buffer[0] += base;
for (int i = 1; i < count; ++i) {
buffer[i] += buffer[i - 1];
long sum = base;
for (int i = 0; i < count; ++i) {
sum += buffer[i];
buffer[i] = sum;
}
}

Expand Down
10 changes: 7 additions & 3 deletions ...a/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,11 +608,13 @@ public Fields get(int doc) throws IOException {
final int[] fSuffixLengths = suffixLengths[i];
final int[] fLengths = lengths[i];
for (int j = 0, end = (int) numTerms.get(skip + i); j < end; ++j) {
// delta-decode start offsets and patch lengths using term lengths
// delta-decode start offsets and patch lengths using term lengths
final int termLength = fPrefixLengths[j] + fSuffixLengths[j];
lengths[i][positionIndex[i][j]] += termLength;
int sum = fStartOffsets[positionIndex[i][j]];
for (int k = positionIndex[i][j] + 1; k < positionIndex[i][j + 1]; ++k) {
fStartOffsets[k] += fStartOffsets[k - 1];
sum += fStartOffsets[k];
fStartOffsets[k] = sum;
fLengths[k] += termLength;
}
}
Expand All @@ -629,8 +631,10 @@ public Fields get(int doc) throws IOException {
if (fPositions != null) {
for (int j = 0, end = (int) numTerms.get(skip + i); j < end; ++j) {
// delta-decode start offsets
int sum = fPositions[fpositionIndex[j]];
for (int k = fpositionIndex[j] + 1; k < fpositionIndex[j + 1]; ++k) {
fPositions[k] += fPositions[k - 1];
sum += fPositions[k];
fPositions[k] = sum;
}
}
}
Expand Down
Loading