Skip to content

Use DirectReader#getMergeInstance for bulk retrieval NumericDocValues #15206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use DirectReader#getMergeInstance for bulk retrieval NumericDocValues #15206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static org.apache.lucene.codecs.lucene90.Lucene90DocValuesFormat.TERMS_DICT_BLOCK_LZ4_SHIFT;

import java.io.IOException;
import java.util.Arrays;
import org.apache.lucene.codecs.CodecUtil;
import org.apache.lucene.codecs.DocValuesProducer;
import org.apache.lucene.index.BaseTermsEnum;
Expand Down Expand Up @@ -432,6 +433,7 @@ private abstract static class DenseNumericDocValues extends NumericDocValues {

final int maxDoc;
int doc = -1;
LongValues bulkValues;

DenseNumericDocValues(int maxDoc) {
this.maxDoc = maxDoc;
Expand Down Expand Up @@ -470,6 +472,33 @@ public long cost() {
public int docIDRunEnd() throws IOException {
return maxDoc;
}

final boolean isDense(int size, int[] docs, int bpv) {
if (size < 2) {
return false;
}
// number of longs in the range of docs
final long longsInRange = (long) (docs[size - 1] - docs[0]) * bpv / 64;

// if every long value will be read, then it is dense (assuming uniform distribution)
if (size < longsInRange) {
return false;
}
return true;
}

/** only call this method when {@link #isDense(int, int[], int)} returned {@code true}. */
void readLongValuesFromBulkInstance(
int size, int[] docs, long[] longValues, RandomAccessInput slice, NumericEntry entry) {
if (bulkValues == null) {
bulkValues = DirectReader.getMergeInstance(slice, entry.bitsPerValue, 0, entry.numValues);
}

for (int i = 0; i < size; ++i) {
longValues[i] = bulkValues.get(docs[i]);
}
advanceExact(docs[size - 1]);
}
}

private abstract static class SparseNumericDocValues extends NumericDocValues {
Expand Down Expand Up @@ -537,6 +566,15 @@ private NumericDocValues getNumeric(NumericEntry entry) throws IOException {
public long longValue() throws IOException {
return entry.minValue;
}

@Override
public void longValues(int size, int[] docs, long[] values, long defaultValue) {
if (size == 0) {
return;
}
Arrays.fill(values, 0, size, entry.minValue);
advanceExact(docs[size - 1]);
}
};
} else {
final RandomAccessInput slice =
Expand All @@ -555,6 +593,8 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return vBPVReader.getLongValue(doc);
}

// todo: override longValues method to use merge instance for vBPVReader?
};
} else {
final LongValues values =
Expand All @@ -566,6 +606,19 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return table[(int) values.get(doc)];
}

@Override
public void longValues(int size, int[] docs, long[] longValues, long defaultValue)
throws IOException {
if (isDense(size, docs, entry.bitsPerValue)) {
readLongValuesFromBulkInstance(size, docs, longValues, slice, entry);
for (int i = 0; i < size; ++i) {
longValues[i] = table[(int) longValues[i]];
}
} else {
super.longValues(size, docs, longValues, defaultValue);
}
}
};
} else if (entry.gcd == 1 && entry.minValue == 0) {
// Common case for ordinals, which are encoded as numerics
Expand All @@ -574,6 +627,16 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return values.get(doc);
}

@Override
public void longValues(int size, int[] docs, long[] longValues, long defaultValue)
throws IOException {
if (isDense(size, docs, entry.bitsPerValue)) {
readLongValuesFromBulkInstance(size, docs, longValues, slice, entry);
} else {
super.longValues(size, docs, longValues, defaultValue);
}
}
};
} else {
final long mul = entry.gcd;
Expand All @@ -583,6 +646,19 @@ public long longValue() throws IOException {
public long longValue() throws IOException {
return mul * values.get(doc) + delta;
}

@Override
public void longValues(int size, int[] docs, long[] longValues, long defaultValue)
throws IOException {
if (isDense(size, docs, entry.bitsPerValue)) {
readLongValuesFromBulkInstance(size, docs, longValues, slice, entry);
for (int i = 0; i < size; ++i) {
longValues[i] = mul * longValues[i] + delta;
}
} else {
super.longValues(size, docs, longValues, defaultValue);
}
}
};
}
}
Expand Down
Loading