[WIP] Concurrent merging with join set algorithm #15208
Draft
+198
−198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #14331 @mayya-sharipova made a great change to introduce this smart algorithm of computing join set and then use it to accelerate the graph merge. This PR tries to make the above algorithm work with the concurrent graph merge.
Progress
I made the first version which just naively let each thread deal with one segment and then handle rest of the nodes like before and get a quite mixed and ineresting benchmark result. Basically the changed code only performs better in 10M doc situation, which kind of making sense since I made it handle one segment per thread, so if there's not enough segments it won't be able to make use of all the threads.
Benchmark
cand
baseline