Skip to content

LUCENE-15108 commit writer before opening DirectoryReader to fix test #15233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LUCENE-15108 commit writer before opening DirectoryReader to fix test #15233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ Bug Fixes
* GITHUB#14847: Allow Faiss vector format to index >2GB of vectors per-field per-segment by using MemorySegment APIs
(instead of ByteBuffer) to copy bytes to native memory. (Kaival Parikh)

* GITHUB#15108: Fixed test failure caused by DirectoryReader.open() reading an index with uncommitted changes. (Vivek Kumar)

* GITHUB#15213: Don't normalize centroids with zero samples, which caused divide-by-zero. (Mike Sokolov)

* GITHUB#15125: Handle inconsistent schema on flush with index sorts (Nhat Nguyen)
Expand Down
4 changes: 2 additions & 2 deletions ...t-framework/src/java/org/apache/lucene/tests/index/LegacyBaseDocValuesFormatTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,14 +1544,14 @@ private void doTestSortedNumericsVsStoredFields(LongSupplier counts, LongSupplie
int id = random().nextInt(numDocs);
writer.deleteDocuments(new Term("id", Integer.toString(id)));
}
try (DirectoryReader reader = maybeWrapWithMergingReader(DirectoryReader.open(dir))) {
try (DirectoryReader reader = maybeWrapWithMergingReader(writer.getReader())) {
TestUtil.checkReader(reader);
compareStoredFieldWithSortedNumericsDV(reader, "stored", "dv");
}
// merge some segments and ensure that at least one of them has more than
// 256 values
writer.forceMerge(numDocs / 256);
try (DirectoryReader reader = maybeWrapWithMergingReader(DirectoryReader.open(dir))) {
try (DirectoryReader reader = maybeWrapWithMergingReader(writer.getReader())) {
TestUtil.checkReader(reader);
compareStoredFieldWithSortedNumericsDV(reader, "stored", "dv");
}
Expand Down
Loading