Skip to content

Minor refactor in ArrayUtils #15288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −7
Open

Minor refactor in ArrayUtils #15288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7ed052
Static string for parse error; remove commented code in ArrayUtils
Oct 3, 2025
2b71461
Revert "Static string for parse error; remove commented code in Array…
sgup432 Oct 3, 2025
33de104
Static string for parse error; remove commented code in ArrayUtils
Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
*/
public final class ArrayUtil {

private static final String PARSING_EXCEPTION_MESSAGE = "Unable to parse";

/** Maximum length for an array (Integer.MAX_VALUE - RamUsageEstimator.NUM_BYTES_ARRAY_HEADER). */
public static final int MAX_ARRAY_LENGTH =
Integer.MAX_VALUE - RamUsageEstimator.NUM_BYTES_ARRAY_HEADER;
Expand Down Expand Up @@ -90,24 +92,21 @@ private static int parse(char[] chars, int offset, int len, int radix, boolean n
for (int i = 0; i < len; i++) {
int digit = Character.digit(chars[i + offset], radix);
if (digit == -1) {
throw new NumberFormatException("Unable to parse");
throw new NumberFormatException(PARSING_EXCEPTION_MESSAGE);
}
if (max > result) {
throw new NumberFormatException("Unable to parse");
throw new NumberFormatException(PARSING_EXCEPTION_MESSAGE);
}
int next = result * radix - digit;
if (next > result) {
throw new NumberFormatException("Unable to parse");
throw new NumberFormatException(PARSING_EXCEPTION_MESSAGE);
}
result = next;
}
/*while (offset < len) {

}*/
if (!negative) {
result = -result;
if (result < 0) {
throw new NumberFormatException("Unable to parse");
throw new NumberFormatException(PARSING_EXCEPTION_MESSAGE);
}
}
return result;
Expand Down
Loading