replace deprecated getOutputName method #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Nov 21, 2024
michael-o
previously requested changes
Nov 21, 2024
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Changes to the reporting methods should only be done when the dust has been settled. The transition has just been completed. These kind of changes should not happen before next year.
Contributor
Author
|
This PR doesn't change the API or remove a deprecated method. Rather it calls the new method instead of the old method, which is something we need to do before we can remove the deprecated method in the future. |
slachiewicz
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.