Skip to content

Add default implementation for deprecated getOutputName method#72

Merged
slawekjaranowski merged 1 commit intoapache:masterfrom
slawekjaranowski:imp-output-name
Mar 31, 2026
Merged

Add default implementation for deprecated getOutputName method#72
slawekjaranowski merged 1 commit intoapache:masterfrom
slawekjaranowski:imp-output-name

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

Without default implementation all child classes have to implement this deprecated method.

We already have information that getOutputPath should be implented instead of it.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Without default implementation all child classes have to implement this deprecated method.

We already have information that getOutputPath should be implented instead of it.
@slawekjaranowski slawekjaranowski self-assigned this Mar 30, 2026
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Mar 30, 2026
@slawekjaranowski slawekjaranowski merged commit a440099 into apache:master Mar 31, 2026
11 checks passed
@slawekjaranowski slawekjaranowski deleted the imp-output-name branch March 31, 2026 14:18
@github-actions github-actions bot added this to the 4.0.1 milestone Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants