Skip to content

Conversation

@perNyfelt
Copy link
Contributor

@perNyfelt perNyfelt commented Nov 6, 2025

This PR fixes the #138 bug by adding a defensive action avoiding the NPE and instead throws a Build Exception with a clear error message that the user needs to register a pom using the pom task. The fix follows the suggestion of the bug reported (Dirk Schnelle-Walka).

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@perNyfelt perNyfelt marked this pull request as ready for review November 7, 2025 21:31
@perNyfelt perNyfelt changed the title add bug reproduced test Defend against NPE when no pom is registered using the pom task prior to using the deploy task (fix for #138) Nov 7, 2025
@perNyfelt perNyfelt closed this Dec 3, 2025
@perNyfelt perNyfelt reopened this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant