HDDS-14934. Enable ConsecutiveAppendsShouldReuse rule in PMD

[ptlrs]

What changes were proposed in this pull request?

This PR enables new PMD rules:
ConsecutiveAppendsShouldReuse Consecutive calls to StringBuffer/StringBuilder .append should be chained, reusing the target object. This can improve the performance by producing a smaller bytecode, reducing overhead and improving inlining

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14934

How was this patch tested?

CI: https://github.com/ptlrs/ozone/actions/runs/23761982025

[Gargi-jais11]

Thanks @ptlrs for the patch.
After you raised the PR there are many places which needs changes for .append chaining in DiskBalancerReportSubcommand. Please update this as well.
Rest LGTM.

[adoroszlai]

Thanks @ptlrs for the patch. I would like to suggest splitting the change for BigIntegerInstantiation into a separate task. While there is only one exact violation, some other BigInteger creation can also be improved. Created HDDS-14955 for that.

[ptlrs]

Thanks for the reviews @Gargi-jais11 @adoroszlai, I have updated the PR. Could you please take another look?

[Gargi-jais11]

Thanks @ptlrs for updating the patch. LGTM!

[adoroszlai]

Thanks @ptlrs for updating the patch, @Gargi-jais11 for the review.