Skip to content

HDDS-14941. Speed up testRetryMessageShownWhenScmUnavailable#10019

Merged
adoroszlai merged 1 commit intoapache:masterfrom
Gargi-jais11:HDDS-14941
Apr 1, 2026
Merged

HDDS-14941. Speed up testRetryMessageShownWhenScmUnavailable#10019
adoroszlai merged 1 commit intoapache:masterfrom
Gargi-jais11:HDDS-14941

Conversation

@Gargi-jais11
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Speed up TestFailoverWithSCMHA#testRetryMessageShownWhenScmUnavailable, which currently takes 3 minutes.

Current situation:

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 254.8 s -- in org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testRetryMessageShownWhenScmUnavailable -- Time elapsed: 188.5 s
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testFailover -- Time elapsed: 33.65 s
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testContainerBalancerPersistsConfigurationInAllSCMs -- Time elapsed: 32.63 s

Fix:
Reduced failover attempt count from 599 failover attempts to 3 failover attempts . It takes 111.1s to run the test now.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14941

How was this patch tested?

Checked in the CI run for test.

Before Fix:

org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 259.7 s

After Fix:

org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.1 s 
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testRetryMessageShownWhenScmUnavailable -- 
Time elapsed: 38.5 s
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testFailover -- Time elapsed: 34.5 s
org.apache.hadoop.hdds.scm.TestFailoverWithSCMHA.testContainerBalancerPersistsConfigurationInAllSCMs -- Time elapsed: 35.63 s

@Gargi-jais11 Gargi-jais11 marked this pull request as ready for review April 1, 2026 09:11
Copy link
Copy Markdown
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoroszlai adoroszlai merged commit 561cbeb into apache:master Apr 1, 2026
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants