Skip to content

HDDS-7373. Add Robot acceptance tests for ozone --validate classpath #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunsarin85 wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −1
Open

HDDS-7373. Add Robot acceptance tests for ozone --validate classpath #10051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion hadoop-ozone/dist/src/main/smoketest/cli/classpath.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,21 @@
# limitations under the License.

*** Settings ***
Documentation Test ozone classpath command
Documentation Test ozone classpath command and --validate classpath checks (HDDS-7373)
Library BuiltIn
Resource ../lib/os.robot
Resource ../ozone-lib/shell.robot
Test Timeout 5 minutes

*** Variables ***
${TEMP_DIR} /tmp

*** Keywords ***
Append missing jar path to classpath descriptor
[arguments] ${ozone_home} ${artifact} ${bogus_jar}
${cp_file} = Set Variable ${ozone_home}/share/ozone/classpath/${artifact}.classpath
Execute sed -i 's_$_:${bogus_jar}_' '${cp_file}'

*** Test Cases ***
Ignores HADOOP_CLASSPATH if OZONE_CLASSPATH is set
[setup] Create File ${TEMP_DIR}/hadoop-classpath.jar
Expand Down Expand Up @@ -48,3 +57,35 @@ Adds optional dir entries
Should Contain ${output} ${jars_dir}/ozone-insight/optional.jar

[teardown] Remove Directory ${OZONE_COPY} recursive=True

Validate classpath succeeds when all jars are present
${output} = Execute ozone --validate classpath ozone-insight
Should Contain ${output} Validating classpath file:
Should Contain ${output} Validation SUCCESSFUL

Validate classpath fails when classpath descriptor is missing
${output} = Execute and checkrc ozone --validate classpath hdds-nonexistent-artifact-7373 1
Should Contain ${output} ERROR: Classpath file descriptor

Validate classpath fails when a listed jar is missing
${OZONE_COPY} = Set Variable ${TEMP_DIR}/ozone-validate-missing-jar
${bogus_jar} = Set Variable ${TEMP_DIR}/ozone-robot-missing-7373.jar
Copy Directory ${OZONE_DIR} ${OZONE_COPY}
Append missing jar path to classpath descriptor ${OZONE_COPY} ozone-insight ${bogus_jar}
${output} = Execute and checkrc ${OZONE_COPY}/bin/ozone --validate classpath ozone-insight 1
Should Contain ${output} ERROR: Jar file ${bogus_jar} is missing
Should Contain ${output} Validation FAILED due to missing jar files!
[teardown] Remove Directory ${OZONE_COPY} recursive=True

Validate with wrong subcommand prints usage
${output} = Execute and checkrc ozone --validate version 1
Should Contain ${output} Usage I: ozone --validate classpath

Validate continue allows daemon command after failed classpath check
${OZONE_COPY} = Set Variable ${TEMP_DIR}/ozone-validate-continue
${bogus_jar} = Set Variable ${TEMP_DIR}/ozone-robot-missing-scm-7373.jar
Copy Directory ${OZONE_DIR} ${OZONE_COPY}
Append missing jar path to classpath descriptor ${OZONE_COPY} hdds-server-scm ${bogus_jar}
${output} = Execute And Ignore Error ${OZONE_COPY}/bin/ozone --validate continue --daemon status scm
Should Contain ${output} Validation FAILED due to missing jar files! Continuing command execution
[teardown] Remove Directory ${OZONE_COPY} recursive=True