Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trino-hdfs:zipunpack withtrino-hdfs:jarcopy (zip artifact no longer published to Maven Central)Breaking SPI changes addressed
ConnectorPageSource.getNextPage()removed; must usegetNextSourcePage()returningSourcePageTrinoPageSource,TrinoPageSourceWrapper,TrinoMergePageSourceWrapper,DirectTrinoPageSource,TableChangesFunctionProcessorgetNextPage()togetNextSourcePage()Connector.shutdown()changed from default to abstractTrinoConnectorshutdown()overrideColumnMetadata.getComment()returnsOptional<String>instead of nullableStringTrinoMetadata.orElse(null)to preserve existing semanticsConnectorSplit.getSplitInfo()removedTrinoSplitMapimportNodeVersionmoved fromio.trino.plugin.hivetoio.trino.spiTrinoConnectorFactoryFileSystemModuleconstructor changed from(String, NodeManager, OpenTelemetry, boolean)to(String, ConnectorContext, boolean)TrinoConnectorFactoryConnectorContextdirectlyJsonCodecFactoryno longer acceptsObjectMapperProvider; requiresJsonMapperTrinoColumnHandleTestJsonMapperProviderAPITrinoTypeTestrow("id" integer, "name" varchar)testDefaultExplainJsonFormat/testLogicalExplainJsonFormatTrinoDistributedQueryTestDependency version changes
Other changes
maven-dependency-plugin:unpackoftrino-hdfs:zipwithcopyoftrino-hdfs:jar. Trino 480 no longer publishes the zip artifact to Maven Central. The transitive HDFS dependencies are already covered by other runtime dependencies in the main plugin directory.extraJavaTestArgswith--add-modules=jdk.incubator.vector --sun-misc-unsafe-memory-access=allow, required by Trino 480 test framework on JDK 25.TrinoColumnHandleTest.javato spotless excludes because spotless incorrectly rewritescom.fasterxml.jacksonimport to paimon-shaded variant.*jdk24*to*jdk25*and updated all JDK version references.Test plan
mvn test— 148 tests pass (unit + distributed query tests)mvn test -Dtest=TrinoITCase— 30 integration tests passmvn package -DskipTests— plugin assembly builds successfully