OMID-309 Load hbase-env.sh and apply HBASE_OPT in startup scripts#188
Draft
stoty wants to merge 1 commit intoapache:masterfrom
Draft
OMID-309 Load hbase-env.sh and apply HBASE_OPT in startup scripts#188stoty wants to merge 1 commit intoapache:masterfrom
stoty wants to merge 1 commit intoapache:masterfrom
Conversation
stoty
changed the title
Contributor
Author
|
I will need to re-think the approach here. |
mnpoonia
reviewed
Apr 4, 2025
| CLASSPATH=$CLASSPATH:$j | ||
| done | ||
|
|
||
| if [ -z ${OMID_OPTS+x} ]; then |
There was a problem hiding this comment.
what if we do something like
OPTS=$OMID_OPTS
if [ -z ${OMID_OPTS+x} ]; then
OPTS="$HBASE_OPTS":"$OPTS";
I am just thinking aloud here.
Contributor
Author
There was a problem hiding this comment.
The problem is that both may have similar options, like -Xmx, in which case it depends on the JVM version if the first or last one gets used.
That's why I want to make sure that HBASE_OPTS is a fallback to OMID_OPTS rather than using both.
Phoenix currently adds both, but I also want to fix that one, because of the possible conflicting options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.