Add support for BookKeeper indexDirectories configuration#645
Merged
lhotari merged 4 commits intoapache:masterfrom Jan 7, 2026
Merged
Add support for BookKeeper indexDirectories configuration#645lhotari merged 4 commits intoapache:masterfrom
lhotari merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@lhotari PTAL. |
lhotari
reviewed
Jan 5, 2026
lhotari
reviewed
Jan 5, 2026
lhotari
approved these changes
Jan 5, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @Denovo1998
Contributor
Author
It's alright, just a small favor. |
lhotari
reviewed
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When running BookKeeper with
DbLedgerStorage, RocksDB index placement (indexDirectories) can have a significant impact on IO behavior and tail latency. The current Helm chart does not provide first-class support for configuringindexDirectoriesor mounting a dedicated volume for it, so index and ledger data often end up sharing the same storage unless users manually customize templates, increasing operational overhead and limiting performance tuning.Modifications
pulsar.bookkeeper.indexDirectorieshelper that supports bothstringandstring[], and defaults tobookkeeper.volumes.index.mountPathwhen an index volume is enabled and no explicit value is provided.indexDirectoriesinto the rendered BookKeeper configuration when applicable (also settingPULSAR_PREFIX_indexDirectories).mkdir -pfor all configuredindexDirectoriespaths to ensure they exist at runtime.bookkeeper.volumes.indexvolume for a dedicated index mount, including PVC/volumeClaimTemplates support and StorageClass generation when needed.values.yamlwith documentation and examples forbookkeeper.volumes.indexandbookkeeper.indexDirectories.Verifying this change