[improve][broker]add active status into cursor stats#17884
Merged
Jason918 merged 1 commit intoapache:masterfrom Oct 1, 2022
Merged
[improve][broker]add active status into cursor stats#17884Jason918 merged 1 commit intoapache:masterfrom
Jason918 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@AnonHxy @codelipenghui @Jason918 @Technoboy- @mattisonchao PTAL thanks. The matching PR pass the tests. |
Contributor
|
LGTM |
AnonHxy
approved these changes
Sep 30, 2022
Jason918
approved these changes
Sep 30, 2022
Contributor
Author
|
/pulsarbot ready-to-test |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The active state indicates whether a cursor is active. And it affects the cache hit rate, because inactive cursors will be evicted from the entry cache. This active state helps to troubleshoot issues with low cache hit rate.
Also it is meaningful for configuring a suitable values for
managedLedgerCursorBackloggedThresholdinServiceConfigurationModifications
Add active status into cursor stats.
It will get the following sample data when getting the
internalStatsof a partitioned topic.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: HQebupt#1