[branch-2.9][cherry-pick] Close TransactionBuffer when MessageDeduplication#checkStatus failed#19287
Merged
codelipenghui merged 8 commits intoapache:branch-2.9from Feb 3, 2023
Merged
Conversation
…kStatus failed (apache#19157) (cherry picked from commit d25cf8e)
4 tasks
Contributor
|
@tjiuming Could you please help check the failed test? It looks like introduced by this PR. |
Contributor
Author
|
/pulsarbot run-failure-checks |
mattisonchao
reviewed
Feb 1, 2023
| } | ||
|
|
||
| @VisibleForTesting | ||
| public void createPersistentTopic0(final String topic, boolean createIfMissing, |
Member
There was a problem hiding this comment.
why don't use BrokerService#getTopic?
Contributor
Author
There was a problem hiding this comment.
yes we can use the method, but when I wrote the test, I chose this method
mattisonchao
reviewed
Feb 1, 2023
| "Replication or dedup check failed." | ||
| + " Removing topic from topics list {}, {}", | ||
| topic, ex); | ||
| persistentTopic.getTransactionBuffer() |
Member
There was a problem hiding this comment.
Should we add this similar logic to line 1395?
Contributor
Author
There was a problem hiding this comment.
Great catch!
it makes sense, in line 1395, it seems like checking create topic timeout, it's also need to close transaction buffer.
I'll create another PR to add the logic
mattisonchao
approved these changes
Feb 1, 2023
gaoran10
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick #19157 into branch-2.9
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: