[improve] Add configuration for NonPeristentTopic expired subscriptions auto clean#19369
Closed
tjiuming wants to merge 1 commit intoapache:masterfrom
Closed
[improve] Add configuration for NonPeristentTopic expired subscriptions auto clean#19369tjiuming wants to merge 1 commit intoapache:masterfrom
tjiuming wants to merge 1 commit intoapache:masterfrom
Conversation
Detroit-69
approved these changes
Jan 31, 2023
mattisonchao
requested changes
Feb 2, 2023
Member
mattisonchao
left a comment
There was a problem hiding this comment.
It's a breaking change. We need to discuss the effect.
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
Closing as no consensus... A mailing list discussion should happen in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For expired subscriptions auto clean, we only a configuration named
subscriptionExpirationTimeMinutes.It works on both
PersistentTopicandNonPersistentTopic.For a
NonPersistentTopic, we can clear its expired subscriptions without psychological burden. But if we enable the expired subscriptions auto clean on aPersistentTopic, it may lead to data loss.This PR introduced a new configuration named
nonPersistentSubscriptionExpirationTimeMinutes, it only works onNonPersistentTopicexpired subscriptions auto clean, but will not affect onPersistentTopic.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: tjiuming#18