Skip to content

[improve] Add configuration for NonPeristentTopic expired subscriptions auto clean#19369

Closed
tjiuming wants to merge 1 commit intoapache:masterfrom
tjiuming:dev/non_persistent_sub_expire
Closed

[improve] Add configuration for NonPeristentTopic expired subscriptions auto clean#19369
tjiuming wants to merge 1 commit intoapache:masterfrom
tjiuming:dev/non_persistent_sub_expire

Conversation

@tjiuming
Copy link
Contributor

@tjiuming tjiuming commented Jan 31, 2023

Motivation

For expired subscriptions auto clean, we only a configuration named subscriptionExpirationTimeMinutes.

It works on both PersistentTopic and NonPersistentTopic.

For a NonPersistentTopic, we can clear its expired subscriptions without psychological burden. But if we enable the expired subscriptions auto clean on a PersistentTopic, it may lead to data loss.

This PR introduced a new configuration named nonPersistentSubscriptionExpirationTimeMinutes, it only works on NonPersistentTopic expired subscriptions auto clean, but will not affect on PersistentTopic.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tjiuming#18

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jan 31, 2023
@tjiuming tjiuming changed the title Add nonPersistentSubscriptionExpirationTimeMinutes configuration [broker][improve] Add configuration for NonPeristentTopic expired subscriptions auto clean Jan 31, 2023
@tjiuming tjiuming changed the title [broker][improve] Add configuration for NonPeristentTopic expired subscriptions auto clean [improve] Add configuration for NonPeristentTopic expired subscriptions auto clean Jan 31, 2023
@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 2, 2023
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change. We need to discuss the effect.

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Mar 5, 2023
@poorbarcode poorbarcode modified the milestones: 3.0.0, 3.1.0 Apr 10, 2023
@tisonkun
Copy link
Member

Closing as no consensus...

A mailing list discussion should happen in advance.

@tisonkun tisonkun closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later. ready-to-test Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants