[fix] [admin] set offload threshold should fail if ns policies is read-only#19383
Merged
lhotari merged 3 commits intoapache:masterfrom Feb 2, 2023
Merged
[fix] [admin] set offload threshold should fail if ns policies is read-only#19383lhotari merged 3 commits intoapache:masterfrom
lhotari merged 3 commits intoapache:masterfrom
Conversation
4 tasks
poorbarcode
changed the title
nicoloboschi
reviewed
Feb 1, 2023
| // ignore. | ||
| } | ||
| // cleanup. | ||
| pulsar.getConfigurationMetadataStore().delete(NamespaceResources.POLICIES_READONLY_FLAG_PATH, |
Contributor
There was a problem hiding this comment.
this must be done in a finally block otherwise, If the test fails, the current state is not cleaned
Contributor
Author
There was a problem hiding this comment.
Already fixed. Thanks
lhotari
approved these changes
Feb 1, 2023
Member
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#19370 (comment) Thanks @lhotari for helping to check
Admin API set offload threshold should fail if namespace policies are read-only.
Modifications
solve the wrong logic and add test.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: