[improve][offload]PIP-211: Introduce Offload throttling, P1#22385
[improve][offload]PIP-211: Introduce Offload throttling, P1#22385dao-jun wants to merge 11 commits intoapache:masterfrom
Conversation
|
Origin PR: #17485 |
lhotari
left a comment
There was a problem hiding this comment.
I think that AsyncTokenBucket should be used for rate limiting instead of implementing a separate solution. It was introduced in PIP-322.
@lhotari |
|
@lhotari I will move AsyncTokenBucket related class from pulsar-broker to pulsar-common, is it OK? |
Yes, I think so. It's worth checking if you could implemented the rate limiting in a similar way as it is in other Pulsar rate limiters that were refactored in PIP-322 implementation. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22385 +/- ##
============================================
+ Coverage 73.57% 73.71% +0.13%
+ Complexity 32624 32404 -220
============================================
Files 1877 1886 +9
Lines 139502 139926 +424
Branches 15299 15326 +27
============================================
+ Hits 102638 103141 +503
+ Misses 28908 28810 -98
- Partials 7956 7975 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/TimeWindow.java
PIP: #18004
Motivation
See #18004
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: