[fix] [test] Fix flaky test ReplicatorTest#22594
Conversation
be08b10 to
ff6afa9
Compare
I think this could be handled with a comment instead. Renaming the file will make following changes harder and I don't think that it provides much clarity. Calling something "dangerous" is very vague and always requires further explanation. That's why comments in the test class or in Pulsar documentation are a better approach to tackle this. |
Makes sense |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespaceAuthZTest.java
Show resolved
Hide resolved
ff6afa9 to
e68575d
Compare
|
@poorbarcode I disabled one problematic test causing OOME in #22586 . Would it be fine to include the revert in this PR or is it better to handle that separately? |
I will review the test |
9a85713 to
d5c4452
Compare
|
Rebase master |
(cherry picked from commit 6fdc0e3)
(cherry picked from commit 6fdc0e3)
Motivation
There are two tests that are not normal operations when using Geo-Replication with a global metadata store, which is should be denied in a production pulsar cluster. they are very dangerous, which leads to a lot of topic deletion and makes namespace policies being incorrect, making other tests in the same class flaky
Replicatortest.testConfigChangeReplicatorGlobalNSTest .testRemoveLocalClusterOnGlobalNamespaceModifications
ReplicatorGlobalNSTestto describe it as the class to run no-normal tests.Replicatortest.testConfigChangeintoReplicatorGlobalNSTestReplicatorGlobalNSTest. testForcefullyTopicDeletionintoReplicatortestDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x