[improve][client] PIP-391: Enable batch index ACK by default#24203
Merged
nodece merged 2 commits intoapache:masterfrom Apr 24, 2025
Merged
[improve][client] PIP-391: Enable batch index ACK by default#24203nodece merged 2 commits intoapache:masterfrom
nodece merged 2 commits intoapache:masterfrom
Conversation
BewareMyPower
added
type/enhancement
BewareMyPower
requested review from
RobertIndie,
dao-jun,
lhotari,
nodece,
poorbarcode,
shibd and
thetumbled
github-actions
bot
added
the
doc
lhotari
reviewed
Apr 23, 2025
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionProduceTest.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Apr 24, 2025
dao-jun
approved these changes
Apr 24, 2025
nodece
approved these changes
Apr 24, 2025
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See #23567
Modifications
Enable
enableBatchIndexAcknowledgment(for client) andacknowledgmentAtBatchIndexLevelEnabled(for broker) by default. Remove all explicit enabling in tests to verify it still works.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#39