Skip to content

[improve][ml] Offload ledgers without check ledger length #24344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poorbarcode merged 4 commits into from
May 27, 2025
Merged

[improve][ml] Offload ledgers without check ledger length #24344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcad024
[improve][ml]Offload ledgers without check ledger length
poorbarcode May 23, 2025
082e8c1
Update tiered-storage/file-system/src/main/java/org/apache/bookkeeper…
poorbarcode May 26, 2025
0d82d93
Update tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mled…
poorbarcode May 26, 2025
4cf5b10
fix typo
poorbarcode May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...g/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,16 @@ private LedgerReader(ReadHandle readHandle,

@Override
public void run() {
if (readHandle.getLength() == 0 || !readHandle.isClosed() || readHandle.getLastAddConfirmed() < 0) {
if (!readHandle.isClosed() || readHandle.getLastAddConfirmed() < 0) {
promise.completeExceptionally(
new IllegalArgumentException("An empty or open ledger should never be offloaded"));
return;
}
if (readHandle.getLength() <= 0) {
log.warn("Ledger [{}] has zero length, but it contains {} entries. "
+ " Attempting to offload ledger since it contains entries.", readHandle.getId(),
readHandle.getLastAddConfirmed() + 1);
}
long ledgerId = readHandle.getId();
final String managedLedgerName = extraMetadata.get(MANAGED_LEDGER_NAME);
String storagePath = getStoragePath(storageBasePath, managedLedgerName);
Expand Down
7 changes: 6 additions & 1 deletion ...va/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,16 @@ public CompletableFuture<Void> offload(ReadHandle readHandle,
final BlobStore writeBlobStore = getBlobStore(config.getBlobStoreLocation());
log.info("offload {} uuid {} extraMetadata {} to {} {}", readHandle.getId(), uuid, extraMetadata,
config.getBlobStoreLocation(), writeBlobStore);
if (readHandle.getLength() == 0 || !readHandle.isClosed() || readHandle.getLastAddConfirmed() < 0) {
if (!readHandle.isClosed() || readHandle.getLastAddConfirmed() < 0) {
promise.completeExceptionally(
new IllegalArgumentException("An empty or open ledger should never be offloaded"));
return;
}
if (readHandle.getLength() <= 0) {
log.warn("[{}] Ledger [{}] has zero length, but it contains {} entries."
+ " Attempting to offload ledger since it contains entries.", topicName, readHandle.getId(),
readHandle.getLastAddConfirmed() + 1);
}
OffloadIndexBlockBuilder indexBuilder = OffloadIndexBlockBuilder.create()
.withLedgerMetadata(readHandle.getLedgerMetadata())
.withDataBlockHeaderLength(BlockAwareSegmentInputStreamImpl.getHeaderSize());
Expand Down
Loading