fix: upgrade kind to v0.27.0 for containerd v2.0 support and add E2E test #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import-images feature was failing with "failed to detect containerd snapshotter" error when using newer kindest/node images (v1.32+) that use containerd v2.0. This was caused by the outdated kind library (v0.20.0) which couldn't properly detect containerd 2.0's snapshotter. Upgrading to kind v0.27.0 resolves this issue as it includes the fix from kubernetes-sigs/kind#3853.
There was a problem hiding this comment.
Pull request overview
Upgrades the kind Go dependency to support containerd v2.0 snapshotter detection and adds a KinD-based E2E test to validate import-images.
Changes:
- Bump
sigs.k8s.io/kindto v0.27.0 (and update related Go module dependencies). - Add a new KinD E2E test suite under
test/e2e/kind/to validateimport-images. - Add
make e2e-test-kindand extend CI workflow to run the KinD E2E test.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Upgrades kind to v0.27.0 and refreshes related dependencies. |
go.sum |
Updates checksums for new/updated module versions. |
test/e2e/kind/kind-cluster.yaml |
Adds KinD cluster config used by the new E2E test. |
test/e2e/kind/e2e.yaml |
Defines the KinD E2E scenario including import-images. |
test/e2e/kind/deployment.yaml |
Test Pod manifest used to validate the imported image runs. |
test/e2e/kind/expected.yaml |
Expected output for the verification step. |
test/e2e/README.md |
Documents the new KinD E2E test directory and make target. |
Makefile |
Adds e2e-test-kind target for running the KinD E2E locally. |
.github/workflows/e2e-test.yaml |
Adds steps to run the KinD E2E test in CI (and installs KinD CLI). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Verify that the import-images feature works correctly after upgrading kind dependency to v0.27.0. - Add test/e2e/kind/ with KinD cluster config, test pod, and expected result - Add e2e-test-kind target in Makefile for local testing - Update CI workflow to run KinD E2E test - Update test/e2e/README.md with new directory structure
fgksgf
force-pushed
the
fix/import-images
branch
from
db2a3e1 to
691dbc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
import-imagesfeature failing with "failed to detect containerd snapshotter" error when using newer kindest/node images (v1.32+) that use containerd v2.0import-imagesfunctionality works correctlyChanges
Dependency upgrade
The outdated kind library (v0.20.0) couldn't properly detect containerd 2.0's snapshotter. Upgrading to kind v0.27.0 resolves this issue as it includes the fix from kubernetes-sigs/kind#3853.
E2E test
test/e2e/kind/directory with KinD cluster config, test pod, and expected resultmake e2e-test-kindtarget for local testing