Skip to content

SOLR-18123: Reduce test reliance on ALLOW_PATHS_SYSPROP #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openworld-maker wants to merge 5 commits into
base: main
Choose a base branch
from
Open

SOLR-18123: Reduce test reliance on ALLOW_PATHS_SYSPROP #4215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9073006
SOLR-18123: Reduce test reliance on ALLOW_PATHS_SYSPROP
kamlendrachauhan Mar 15, 2026
9097614
Merge remote-tracking branch 'upstream/main' into pr/4215
epugh Mar 18, 2026
c7814df
tidy
epugh Mar 18, 2026
ed3c3a3
Fix merge error
epugh Mar 18, 2026
0161fb7
SOLR-18123: move allow-paths setup from SolrTestCase to affected tests
openworld-maker Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ public static void beforeTest() throws Exception {
.withServlet(new ServletHolder(SlowStreamServlet.class), SLOW_STREAM_SERVLET_REGEX)
.withSSLConfig(sslConfig.buildServerSSLConfig())
.build();

EnvUtils.setProperty(
ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
solrTestRule.startSolr(createTempDir(), new Properties(), jettyConfig);
Expand Down
5 changes: 0 additions & 5 deletions .../test-framework/src/test/org/apache/solr/client/solrj/apache/BasicHttpSolrClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package org.apache.solr.client.solrj.apache;

import static org.apache.solr.core.CoreContainer.ALLOW_PATHS_SYSPROP;

import jakarta.servlet.http.Cookie;
import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -68,7 +66,6 @@
import org.apache.solr.common.SolrInputDocument;
import org.apache.solr.common.params.CommonParams;
import org.apache.solr.common.params.ModifiableSolrParams;
import org.apache.solr.common.util.EnvUtils;
import org.apache.solr.common.util.NamedList;
import org.apache.solr.embedded.JettyConfig;
import org.apache.solr.util.ExternalPaths;
Expand Down Expand Up @@ -100,8 +97,6 @@ public static void beforeTest() throws Exception {
.withServlet(new ServletHolder(DebugServlet.class), "/debug/*")
.withServlet(new ServletHolder(SlowStreamServlet.class), "/slowStream/*")
.build();
EnvUtils.setProperty(
ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
solrTestRule.startSolr(createTempDir(), new Properties(), jettyConfig);
solrTestRule.newCollection().withConfigSet(ExternalPaths.TECHPRODUCTS_CONFIGSET).create();
}
Expand Down
5 changes: 0 additions & 5 deletions .../src/test/org/apache/solr/client/solrj/apache/ConcurrentUpdateSolrClientBadInputTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,10 @@

package org.apache.solr.client.solrj.apache;

import static org.apache.solr.core.CoreContainer.ALLOW_PATHS_SYSPROP;

import java.util.ArrayList;
import java.util.List;
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.common.util.EnvUtils;
import org.apache.solr.util.ExternalPaths;
import org.apache.solr.util.SolrJettyTestRule;
import org.junit.BeforeClass;
Expand All @@ -42,8 +39,6 @@ public class ConcurrentUpdateSolrClientBadInputTest extends SolrTestCaseJ4 {

@BeforeClass
public static void beforeTest() throws Exception {
EnvUtils.setProperty(
ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
solrTestRule.startSolr();
solrTestRule.newCollection().withConfigSet(ExternalPaths.TECHPRODUCTS_CONFIGSET).create();
}
Expand Down
6 changes: 0 additions & 6 deletions ...ramework/src/test/org/apache/solr/client/solrj/apache/ConcurrentUpdateSolrClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package org.apache.solr.client.solrj.apache;

import static org.apache.solr.core.CoreContainer.ALLOW_PATHS_SYSPROP;

import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServlet;
import jakarta.servlet.http.HttpServletRequest;
Expand All @@ -41,7 +39,6 @@
import org.apache.solr.client.solrj.request.SolrQuery;
import org.apache.solr.client.solrj.request.UpdateRequest;
import org.apache.solr.common.SolrInputDocument;
import org.apache.solr.common.util.EnvUtils;
import org.apache.solr.common.util.ExecutorUtil;
import org.apache.solr.common.util.SolrNamedThreadFactory;
import org.apache.solr.embedded.JettyConfig;
Expand Down Expand Up @@ -139,9 +136,6 @@ public void update(
public static void beforeTest() throws Exception {
JettyConfig jettyConfig =
JettyConfig.builder().withServlet(new ServletHolder(TestServlet.class), "/cuss/*").build();

EnvUtils.setProperty(
ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
solrTestRule.startSolr(createTempDir(), new Properties(), jettyConfig);
solrTestRule.newCollection().withConfigSet(ExternalPaths.TECHPRODUCTS_CONFIGSET).create();
}
Expand Down
5 changes: 0 additions & 5 deletions ...est-framework/src/test/org/apache/solr/client/solrj/apache/HttpSolrClientConPoolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package org.apache.solr.client.solrj.apache;

import static org.apache.solr.core.CoreContainer.ALLOW_PATHS_SYSPROP;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
Expand All @@ -34,7 +32,6 @@
import org.apache.solr.client.solrj.request.UpdateRequest;
import org.apache.solr.common.SolrInputDocument;
import org.apache.solr.common.params.ModifiableSolrParams;
import org.apache.solr.common.util.EnvUtils;
import org.apache.solr.common.util.ExecutorUtil;
import org.apache.solr.common.util.SolrNamedThreadFactory;
import org.apache.solr.util.ExternalPaths;
Expand All @@ -51,8 +48,6 @@ public class HttpSolrClientConPoolTest extends SolrTestCaseJ4 {

@BeforeClass
public static void beforeTest() throws SolrServerException, IOException {
EnvUtils.setProperty(
ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
solrTestRule.startSolr();
solrTestRule.newCollection().withConfigSet(ExternalPaths.TECHPRODUCTS_CONFIGSET).create();

Expand Down