code review

vrozov · vrozov · commit 1ef4d06f7a26 · 2025-11-19T10:06:39.000-08:00
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
@@ -295,7 +295,6 @@ private[orc] class OrcOutputWriter(
   }
 
   override def write(row: InternalRow): Unit = {
-    // getOrCreateInternalWriter()
     recordWriter.write(NullWritable.get(), serializer.serialize(row))
   }
 
@@ -317,8 +316,6 @@ private[orc] class OrcOutputWriter(
       // For empty write task, we need to create it manually to record our meta.
       val options = OrcFile.writerOptions(context.getConfiguration)
         .inspector(serializer.structOI)
-        // .setProlepticGregorian(true)
-        // .useUTCTimestamp(true)
       writer = OrcFile.createWriter(new Path(path), options)
       // set the writer to make it flush meta on close
       writerField.set(recordWriter, writer)

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,6 @@ private[orc] class OrcOutputWriter(`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`override def write(row: InternalRow): Unit = {`
`298`		`- // getOrCreateInternalWriter()`
`299`	`298`	`recordWriter.write(NullWritable.get(), serializer.serialize(row))`
`300`	`299`	`}`
`301`	`300`
`@@ -317,8 +316,6 @@ private[orc] class OrcOutputWriter(`
`317`	`316`	`// For empty write task, we need to create it manually to record our meta.`
`318`	`317`	`val options = OrcFile.writerOptions(context.getConfiguration)`
`319`	`318`	`.inspector(serializer.structOI)`
`320`		`- // .setProlepticGregorian(true)`
`321`		`- // .useUTCTimestamp(true)`
`322`	`319`	`writer = OrcFile.createWriter(new Path(path), options)`
`323`	`320`	`// set the writer to make it flush meta on close`
`324`	`321`	`writerField.set(recordWriter, writer)`