[SPARK-53181][PS] Enable doc tests under ANSI #51910
Closed
+0
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
force-pushed
the
import_doctest
branch
from
956862c to
a3628b0
Compare
xinrong-meng
changed the title
xinrong-meng
commented
Aug 7, 2025
| @@ -3895,7 +3895,6 @@ def _test() -> None: | |||
|
|
|||
| if is_ansi_mode_test: | |||
There was a problem hiding this comment.
melt has an issue and will be resolved and enabled in a seperate PR.
zhengruifeng
approved these changes
Aug 8, 2025
|
qq: how is doc tests and unit tests ran under ANSI? do we have a scheduled job in OSS? |
|
We turn on ANSI by default in CI/PR builders, and nightly we have ANSI off jobs running, does that answer your concern? @zhengruifeng |
|
Merged to master thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable doc tests under ANSI
Why are the changes needed?
Test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test changes only
Was this patch authored or co-authored using generative AI tooling?
No