[SPARK-54373][UI] Enlarge the SVG viewBox attribute of Job DAG initialization #53087
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enlarges the initial SVG viewBox attribute for Job DAG visualization to improve rendering quality during the painting phase. The viewBox is expanded from a fixed 100x100 window to use the available screen width by 1000 pixels.
Key Changes:
- Modified the SVG initialization to set an initial viewBox using
window.screen.availWidthand a height of 1000 pixels - Refactored the SVG creation from a single-line chain to a multi-line statement for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
Outdated
Show resolved
Hide resolved
core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
Outdated
Show resolved
Hide resolved
…iz.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
HyukjinKwon
approved these changes
Nov 18, 2025
Member
Author
|
Thank you, @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enlarge the SVG viewBox attribute of Job DAG initialization from a 100*100 window to an available width of the window * 1000.
Why are the changes needed?
improve the visualization while the graphics are being painted
Does this PR introduce any user-facing change?
No, the final sizes of these SVGs will be adjusted to the actual needs
How was this patch tested?
tested in Chrome DevTools
Was this patch authored or co-authored using generative AI tooling?
no