[ci] Re-balance shards#12473
Merged
areusch merged 1 commit intoapache:mainfrom Sep 7, 2022
driazati:reblance2
Merged
Conversation
Contributor
driazati
added a commit
to tlc-pack/ci
that referenced
this pull request
Aug 23, 2022
This re-uses some code from the `monitoring/` dir with random modifications (maybe in the future we could de-duplicate these) but for now the code is fairly spaghetti-esque. `determine_shards.py` helps generate content for PRs like apache/tvm#12473
driazati
added a commit
to tlc-pack/ci
that referenced
this pull request
Aug 23, 2022
This re-uses some code from the `monitoring/` dir with random modifications (maybe in the future we could de-duplicate these) but for now the code is fairly spaghetti-esque. `determine_shards.py` helps generate content for PRs like apache/tvm#12473
driazati
added a commit
to tlc-pack/ci
that referenced
this pull request
Aug 23, 2022
This re-uses some code from the `monitoring/` dir with random modifications (maybe in the future we could de-duplicate these) but for now the code is fairly spaghetti-esque. `determine_shards.py` helps generate content for PRs like apache/tvm#12473
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
commented
Sep 6, 2022
| if [[ "${TEST_STEP_NAME:-default}" == "frontend: GPU"* ]] || [[ "${TEST_STEP_NAME:-default}" == "test: Hexagon"* ]]; then | ||
| DEFAULT_PARALLELISM=1 | ||
| fi | ||
| DEFAULT_PARALLELISM=1 |
Member
Author
There was a problem hiding this comment.
The n=2 wasn't actually being used (the if below was always failing) and caused some CI issues that should be resolved in a follow up
areusch
approved these changes
Sep 7, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
neat! should we add rebalance instructions to monitoring rotation runbook?
Member
Author
good idea, done in: https://github.com/apache/tvm/wiki/CI-Monitoring-Runbook#test-sharding |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Replace '> >' in templates with >>, NFC (apache#12615) The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s. Co-authored-by: Krzysztof Parzyszek <kparzysz@quicinc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses numbers from this script: tlc-pack/ci#51 that determines the number of shards to use given a goal runtime (in this case 60 minutes for tests)
cc @Mousius @areusch @gigiblender