Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/tvm/contrib/mrvl.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def get_nodes_json_string(graph_json):

@tvm_ffi.register_global_func("tvm.mrvl.ModifyConstNames")
def modify_const_names(nodes_json_str, consts_json_str):
"""This takes the graph module returned by build an generates nodes and constant
"""This takes the graph module returned by build and generates nodes and constant
meta data suitable for compilation by the back end.

Parameters
Expand All @@ -222,7 +222,7 @@ def modify_const_names(nodes_json_str, consts_json_str):
-------
modified_nodes_consts: string
This returns a concatenated string of the nodes_json and modified
consts json file, seperated by a delimiter |. The modification to the
consts json file, separated by a delimiter |. The modification to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Good catch on this typo. I found another one in the same docstring on line 210: ... by build an generates ... should probably be ... by build and generates ....

consts file is necessary since we have added the Merge Compiler Pass
which names the constants in a form unsuitable for the backend.
"""
Expand Down
4 changes: 2 additions & 2 deletions python/tvm/relax/transform/transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -1618,13 +1618,13 @@ def AllocateWorkspace() -> tvm.ir.transform.Pass:

def SpecializePrimFuncBasedOnCallSite() -> tvm.ir.transform.Pass:
"""This pass updates the var_buffer mapping of PrimFunctions from the call_tir info.
Primarily used to update the VDevice information if any changes occured from the caller.
Primarily used to update the VDevice information if any changes occurred from the caller.
This pass recreates the buffers and updates the map.
Returns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for the return value on line 1627 appears to be incorrect. It seems to have been copied from the AllocateWorkspace function. It should describe what SpecializePrimFuncBasedOnCallSite returns, for example: 'The registered pass for specializing PrimFuncs based on call site.'

-------
ret: tvm.ir.transform.Pass
The registered pass for allocating workspace.
The registered pass for specializing PrimFuncs based on call site.
"""
return _ffi_api.SpecializePrimFuncBasedOnCallSite() # type: ignore

Expand Down