[YUNIKORN-3081] Remove pods get from admission controller cluster role #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admission controller code does not reference the pod retrieval. That means it should not need the permission on a role.
pbacsko
approved these changes
Jun 12, 2025
Contributor
Author
|
Locally ran the e2e tests against 2 different K8s versions and have not seen any issue with failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The admission controller code does not reference the pod retrieval. That means it should not need the permission on a role. Making it configurable for now to allow integration and troubleshooting through the e2e tests if needed.
What type of PR is it?
What is the Jira issue?
How should this be tested?
The change was made to fix e2e tests 3 years ago. If this is still required the e2e tests in the k8shim should fail