Conversation
Member
Author
|
@skn96 I'll look into this next week, it looks like we may have to pass some additional argument, or compute the nPoly differently in the caller. |
Waf Unit Tests 2 files 2 suites 0s ⏱️ Results for commit 06af97e. ♻️ This comment has been updated with latest results. |
System Tests58 tests 58 ✅ 25m 20s ⏱️ Results for commit 06af97e. ♻️ This comment has been updated with latest results. |
Using a different path for the artifact upload.
Replaces the unstable configuration with a stable one.
Member
Author
|
@skn96 this is now ready to be merged from my point of view if you don't have any objections. |
skn96
reviewed
Nov 13, 2025
Contributor
skn96
left a comment
skn96
left a comment
There was a problem hiding this comment.
Hi Harald, I also have no problems with merging the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR in ateles-source.