Skip to content

Use the apes-suite/build-action to compile seeder#13

Merged
haraldkl merged 4 commits intomainfrom
build-action
May 21, 2025
Merged

Use the apes-suite/build-action to compile seeder#13
haraldkl merged 4 commits intomainfrom
build-action

Conversation

@haraldkl
Copy link
Copy Markdown
Member

Instead of installing additional dependencies, make use of the docker action
that runs the waf command accordingly.

@haraldkl haraldkl self-assigned this May 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2025

Waf Unit Tests

  2 files    2 suites   0s ⏱️
 69 tests  69 ✅ 0 💤 0 ❌
138 runs  138 ✅ 0 💤 0 ❌

Results for commit 05b59da.

♻️ This comment has been updated with latest results.

@haraldkl haraldkl marked this pull request as ready for review May 21, 2025 12:42
@haraldkl haraldkl added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 6022b70 May 21, 2025
2 checks passed
@haraldkl haraldkl deleted the build-action branch May 21, 2025 12:56
@MikeW097
Copy link
Copy Markdown
Member

@haraldkl Thanks for introducing the new feature. I guess this feature will be automatically tested when we make changes, correct?

@haraldkl
Copy link
Copy Markdown
Member Author

@MikeW097 yes the tests are run automatically when you push new changes into a pull request.
However, there is a quirk with the submodules: pushing in the submodules does not trigger any checks. Only when something gets pushed to the parent directory the tests are run there. So in the case of Seeder here: if you push to seeder-source this does not immediately translate into a check being run. My suggestion is to use the bin/request script instead of git push in the respective submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants