Conversation
(some 'black' fixes also snuck in, mostly related to white space) No intentional functinoal changes.
No intentional functional change
|
Hi @apetrycki, I wanted to give you a look at something I've been working on. I believe with this commit 1/ the code is cleaner and will have a more consistent style and 2/ there will be a mechanism in place to catch simple bugs (using flake8 is how I found #132) which improves reliability of the code. You can see an example of the GitHub action run here. This is mostly finished, but I may still tinker with it. There are no intentional functional changes, but I'm running with these linting fixes just to be sure. |
knightjoel
force-pushed
the
chore/linting
branch
from
5f4a86e to
44b5ddb
Compare
|
@knightjoel What is your feeling at this point? Should I merge it all in, or are you still working on some things? |
|
Hello! This is ready to merge. |
| sensors.append({"name": f"{name} Indoor", "value": thermostat['aqIndoorParticlesValue'], "type": "particle"}) | ||
| sensors.append({"name": f"{name} Indoor", "value": thermostat['aqIndoorValue'], "type": "score"}) | ||
| sensors.append({"name": f"{name} Indoor", "value": thermostat['aqIndoorVOCValue'], "type": "VOC"}) | ||
| sensors.append( |
There was a problem hiding this comment.
The formatting for these sensors.appends is kinda painful. Is there a way to exclude this section from the auto formatting?
2 participants
To ensure no regressions: