Skip to content

Conversation

mateuszzw
Copy link

@mateuszzw mateuszzw commented Aug 16, 2022

Hi @ImJohnMDaniel
Since our team had a need for a method that adds to already existing conditions and not just setting them, here's my pull request to add that functionality. Feel free to comment, I'm really curious what you think :)


This change is Reviewable

@mateuszzw
Copy link
Author

Hi @ImJohnMDaniel it's open for a long time already. I know you're probably extra busy, but is there any chance for you to take a look at it? Thanks!

@chazwatkins
Copy link

@ImJohnMDaniel @stohn777 This looks interesting. What are you're thoughts on this being included?

@ImJohnMDaniel
Copy link
Contributor

This change is under review but we are currently focusing on efforts to incorporate USER_MODE. Once we get this stable, then we will focus on other efforts like this.

@daveespo
Copy link
Contributor

daveespo commented Sep 8, 2025

We're going to close this out for the same reasons as cited on #483 -- this adds a limited version of a query builder that won't serve the more complex (nested/parenthesized boolean logic) needs that others have requested. Thank you for your hard work but it doesn't address a use case that we plan to address.

@daveespo daveespo closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants