tests: test parameters type detection #7240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentchalamon
force-pushed
the
fix/parameter-type-detection
branch
5 times, most recently
from
3f4932a to
4f58677
Compare
soyuka
requested changes
Jun 26, 2025
...Validator/Metadata/Resource/Factory/ParameterValidationResourceMetadataCollectionFactory.php
Outdated
Show resolved
Hide resolved
|
|
||
| // Allow null in case of optional parameter | ||
| if (isset($schema['type']) && 'boolean' === $schema['type']) { | ||
| $assertions[] = new Expression(expression: 'value in [null, 0, 1, "0", "1", false, true, "false", "true"]'); |
There was a problem hiding this comment.
I'm not a huge fan of using an expression, I'd prefer to use Assert\IsTrue or Assert\IsFalse or why not even Assert\Type. This leads to the same issue as above that is that parameters are always strings. Suggestion: let's add a new castToNativeType option on parameters, if its true we can cast the string to the native type inside the ApiPlatform\State\Provider\ParameterProvider (there's a function in type info for that IIRC). Then, if castToNativeType is true we can safely add an Assert\Type constraint.
There was a problem hiding this comment.
@soyuka does the last commit suit your proposition?
I considered the following:
- if
nativeType: new BuiltinType(TypeIdentifier::BOOL)is set, cast value to bool - if
schema: ['type' => 'boolean']ANDcastToNativeType: true, cast value to bool
vincentchalamon
force-pushed
the
fix/parameter-type-detection
branch
4 times, most recently
from
bb82236 to
27dda8c
Compare
vincentchalamon
force-pushed
the
fix/parameter-type-detection
branch
3 times, most recently
from
9035ac8 to
0652118
Compare
soyuka
force-pushed
the
fix/parameter-type-detection
branch
5 times, most recently
from
753ce17 to
7d4dc73
Compare
soyuka
force-pushed
the
fix/parameter-type-detection
branch
from
7d4dc73 to
c4e4bb7
Compare
|
Thanks @vincentchalamon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.