-
Notifications
You must be signed in to change notification settings - Fork 164
feat: Better describe the circumstances under which run usage info is included in API responses #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janbuchar
wants to merge
5
commits into
master
Choose a base branch
from
describe-get-run-response-better
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Better describe the circumstances under which run usage info is included in API responses #2179
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2545152
Simplify nullable fields
janbuchar e549938
feat: Better describe the circumstances under which run usage infor i…
janbuchar d92e3f1
Update apify-api/openapi/components/schemas/actor-runs/Run.yaml
janbuchar c2af22a
Update apify-api/openapi/components/schemas/actor-runs/Run.yaml
janbuchar 9fb19a2
Update apify-api/openapi/components/schemas/actor-runs/Run.yaml
janbuchar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,18 +93,21 @@ properties: | |
| nullable: true | ||
| example: master | ||
| usage: | ||
| allOf: | ||
| - oneOf: | ||
| - nullable: true | ||
| - $ref: ./RunUsage.yaml | ||
| - {} | ||
| nullable: true | ||
| $ref: ./RunUsage.yaml | ||
| usageTotalUsd: | ||
| type: number | ||
| nullable: true | ||
| description: >- | ||
| Total cost in USD for this run. Represents what you actually pay. | ||
| For run owners: includes platform usage (compute units) and/or event costs depending on the Actor's pricing model. | ||
| For non-owners: only available for Pay-Per-Event Actors (event costs only). | ||
| Not available for Pay-Per-Result Actors when you're not the Actor owner. | ||
| example: 0.2654 | ||
| usageUsd: | ||
| allOf: | ||
| - oneOf: | ||
| - nullable: true | ||
| - $ref: ./RunUsage.yaml | ||
| - {} | ||
| nullable: true | ||
| description: >- | ||
| Platform usage costs breakdown in USD. Only present if you own the run AND are paying for platform usage | ||
| (Pay-Per-Usage, Rental, or Pay-Per-Event with usage costs like standby Actors). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am technically missing there "if you are Actor owner" case - you are then only paying for usage
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That seems like too much detail to me honestly... |
||
| Not available for standard Pay-Per-Event Actors or Pay-Per-Result Actors owned by others. | ||
| $ref: ./RunUsage.yaml | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on pricing model - yes - but also depends on "if you own the Actor" 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this is written under "For run owners:", so the "if you own the Actor" condition is already satisfied, right?